v0.0.68

cmdext/cmdrunner.go

@@ -14,9 +14,9 @@ type CommandResult struct {
 	CommandTimedOut bool
 }
 
-func RunCommand(program string, args []string, timeout *time.Duration) (CommandResult, error) {
-
-	cmd := exec.Command(program, args...)
+func run(opt CommandRunner) (CommandResult, error) {
+	cmd := exec.Command(opt.program, opt.args...)
+	cmd.Env = append(cmd.Env, opt.env)
 
 	stdoutPipe, err := cmd.StdoutPipe()
 	if err != nil {
@@ -75,68 +75,42 @@ func RunCommand(program string, args []string, timeout *time.Duration) (CommandR
 		}
 	}()
 
-	if timeout != nil {
+	var timeoutChan <-chan time.Time = make(chan time.Time, 1)
+	if opt.timeout != nil {
+		timeoutChan = time.After(*opt.timeout)
+	}
 
-		select {
+	select {
 
-		case <-time.After(*timeout):
-			_ = cmd.Process.Kill()
+	case <-timeoutChan:
+		_ = cmd.Process.Kill()
+		return CommandResult{
+			StdOut:          stdout,
+			StdErr:          stderr,
+			StdCombined:     stdcombined,
+			ExitCode:        -1,
+			CommandTimedOut: true,
+		}, nil
+
+	case err := <-errch:
+		if exiterr, ok := err.(*exec.ExitError); ok {
 			return CommandResult{
 				StdOut:          stdout,
 				StdErr:          stderr,
 				StdCombined:     stdcombined,
-				ExitCode:        -1,
-				CommandTimedOut: true,
+				ExitCode:        exiterr.ExitCode(),
+				CommandTimedOut: false,
+			}, nil
+		} else if err != nil {
+			return CommandResult{}, err
+		} else {
+			return CommandResult{
+				StdOut:          stdout,
+				StdErr:          stderr,
+				StdCombined:     stdcombined,
+				ExitCode:        0,
+				CommandTimedOut: false,
 			}, nil
-
-		case err := <-errch:
-			if exiterr, ok := err.(*exec.ExitError); ok {
-				return CommandResult{
-					StdOut:          stdout,
-					StdErr:          stderr,
-					StdCombined:     stdcombined,
-					ExitCode:        exiterr.ExitCode(),
-					CommandTimedOut: false,
-				}, nil
-			} else if err != nil {
-				return CommandResult{}, err
-			} else {
-				return CommandResult{
-					StdOut:          stdout,
-					StdErr:          stderr,
-					StdCombined:     stdcombined,
-					ExitCode:        0,
-					CommandTimedOut: false,
-				}, nil
-			}
-
-		}
-
-	} else {
-
-		select {
-
-		case err := <-errch:
-			if exiterr, ok := err.(*exec.ExitError); ok {
-				return CommandResult{
-					StdOut:          stdout,
-					StdErr:          stderr,
-					StdCombined:     stdcombined,
-					ExitCode:        exiterr.ExitCode(),
-					CommandTimedOut: false,
-				}, nil
-			} else if err != nil {
-				return CommandResult{}, err
-			} else {
-				return CommandResult{
-					StdOut:          stdout,
-					StdErr:          stderr,
-					StdCombined:     stdcombined,
-					ExitCode:        0,
-					CommandTimedOut: false,
-				}, nil
-			}
-
 		}
 	}
 }